[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, the Finale

Guillaume Poirier gpoirier at mplayerhq.hu
Wed Jun 6 16:02:32 CEST 2007


Hi,

Zuxy Meng wrote:

> ------------------------------------------------------------------------
> 
> Index: mp3lib/sr1.c
> ===================================================================
> --- mp3lib/sr1.c	(版本 23483)
> +++ mp3lib/sr1.c	(工作副本)
> @@ -32,8 +32,9 @@
>  
>  #include "libvo/fastmemcpy.h"
>  
> -#ifdef ARCH_X86_32
> -#define CAN_COMPILE_X86_ASM
> +#ifdef ARCH_X86_64
> +#undef HAVE_3DNOW
> +#undef HAVE_3DNOWEX

The reason why you undef HAVE_3DNOW and HAVE_3DNOWEX is because dct36*
routines can't be compiled on AMD64 yet, right? (dct64_3dnow.o
dct64_k7.o can be compiled though)
Do you have any plans to clean them up as you did with SSE
counterparts? I'm just curious, it's OK if you don't.

Other than that, the patch look OK to me. Maybe Reimar will comment,
so wait a bit before comitting.

When you do commit, please update changelog.

Guillaume



More information about the MPlayer-dev-eng mailing list