[MPlayer-dev-eng] [PATCH] mp3lib: Align output so that movaps can be used instead of movups

Guillaume POIRIER poirierg at gmail.com
Mon Jun 4 13:09:11 CEST 2007


Hi,

On 6/4/07, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> 2007/6/4, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Mon, Jun 04, 2007 at 10:00:00AM +0200, Guillaume Poirier wrote:
> > [...]
> > > Alternatively, maybe DECLARE_ALIGNED_16() and friends should be moved
> > > to a different, separate include, but that's probably overkill.
> >
> > I'd say they probably could just be moved to mem.h...
>
> It's a bit more complex than I expected after I examined
> dsputil.h...Anyway this patch works fine.

I'm OK with that patch. If DECLARE_ALIGNED_x go get moved to mem.h,
then maybe mp3lib should use them, but that's really a minor issue.

Patch OK with me, commit whenever you want, it's good to see some
TODO/FIXME items getting killed.

Guillaume
-- 
Y'a pas de gonzesse hooligan,
Imbécile et meurtrière
Y'en a pas même en grande Bretagne
A part bien sûr Madame Thatcher
  -- Renaud (sur "Miss Maggie")


More information about the MPlayer-dev-eng mailing list