[MPlayer-dev-eng] [PATCH] mp3lib: Align output so that movaps can be used instead of movups

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jun 4 13:18:08 CEST 2007


Hello,
On Mon, Jun 04, 2007 at 05:27:49PM +0800, Zuxy Meng wrote:
> 2007/6/4, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >On Mon, Jun 04, 2007 at 10:00:00AM +0200, Guillaume Poirier wrote:
> >[...]
> >> Alternatively, maybe DECLARE_ALIGNED_16() and friends should be moved
> >> to a different, separate include, but that's probably overkill.
> >
> >I'd say they probably could just be moved to mem.h...
> 
> It's a bit more complex than I expected after I examined
> dsputil.h...Anyway this patch works fine.

> -    static real hybridIn[2][SBLIMIT][SSLIMIT];
> -    static real hybridOut[2][SSLIMIT][SBLIMIT];
> +    DECLARE_ALIGNED(16, real, hybridIn[2][SBLIMIT][SSLIMIT]);
> +    DECLARE_ALIGNED(16, real, hybridOut[2][SSLIMIT][SBLIMIT]);

I think you meant
static DECLARE_ALIGNED(16, real, hybridIn[2][SBLIMIT][SSLIMIT]);
If you want to drop the static do it in a seperate patch (there is
at least one other place like this).

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list