[MPlayer-dev-eng] [PATCH] mp3lib: Align output so that movaps can be used instead of movups

[Alban Bedel]

On Mon, 4 Jun 2007 14:54:01 +0800
"Zuxy Meng" <zuxy.meng at gmail.com> wrote:

> > > The attached patch aligns output address of dct64 functions to 16-byte
> > > boundary, so movaps can be used instead of movups in dct64_sse,
> > > resulting in 2.5% faster decode.
> >
> > I think it's better to use DECLARE_ALIGNED_16() macros. If they aren't
> > available in mp3lib, then I think it's OK to add #include the relevant
> > file from lavc.
> >
> > If someone disagrees with this, please speak up!
> 
> I did a grep and found that outside ffmpeg, mplayer uses
> __attribute__((aligned())) directly, as is the case for existing code
> in mp3lib (see dct64_k7.c for example).

I expected this :) MPlayer is full of various crap, the right solution is
evidently to fix the crap and not propagating it.

	Albeu