[MPlayer-dev-eng] [PATCH] mp3lib: Align output so that movaps can be used instead of movups

[Zuxy Meng]

Hi,

2007/6/4, Guillaume POIRIER <poirierg at gmail.com>:
> Hi,
>
> On 6/4/07, Zuxy Meng <zuxy.meng at gmail.com> wrote:
>
> > The attached patch aligns output address of dct64 functions to 16-byte
> > boundary, so movaps can be used instead of movups in dct64_sse,
> > resulting in 2.5% faster decode.
>
> I think it's better to use DECLARE_ALIGNED_16() macros. If they aren't
> available in mp3lib, then I think it's OK to add #include the relevant
> file from lavc.
>
> If someone disagrees with this, please speak up!

I did a grep and found that outside ffmpeg, mplayer uses
__attribute__((aligned())) directly, as is the case for existing code
in mp3lib (see dct64_k7.c for example).

> > I tested against mp3 and mp2 and both worked fine; couldn't find an
> > mp1 sample though.
>
> I think that should be one:
> http://samples.mplayerhq.hu/A-codecs/MP3/mpeg_layer1_audio.mpg

Yes it is and it works fine. Thanks!
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6