[MPlayer-dev-eng] [PATCH] Refreshed OS/2 Patches
Diego Biurrun
diego at biurrun.de
Mon Jul 30 10:51:11 CEST 2007
On Mon, Jul 30, 2007 at 04:12:06PM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
> > On Sun, Jul 29, 2007 at 11:00:52PM +0900, KO Myung-Hun wrote:
> >
> >> Attila Kinali wrote:
> >>
> >>> On Tue, 17 Jul 2007 22:41:00 +0900
> >>> KO Myung-Hun <komh at chollian.net> wrote:
> >>>
> >>> And finally you should split the kva and dart patches
> >>> (rule of thumb: things that do not depend on each other should
> >>> be in different patches).
> >>>
> >> I have questions.
> >>
> >> configure script has patches for both kva and dart. In this case, should
> >> I split configure script into kva and dart, respectively ?
> >>
> >> And in the case of common parts, what should I do ? That is, configure
> >> script has common code for both kva and dart. Should I include those
> >> codes to both kva and dart pathces ?
> >
> > There is no common kva and dart code in your configure patch.
>
> I think the codes to add '-lmmpm2' for kva or dart are common. Am I wrong ?
This is used by both, yes. Make one patch add the code and the other
add the second condition.
Diego
More information about the MPlayer-dev-eng
mailing list