[MPlayer-dev-eng] [PATCH] Remove global variables from tv.c
Vladimir Voroshilov
voroshil at gmail.com
Sun Jul 29 09:58:39 CEST 2007
Hi, Reimar
2007/7/28, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Jul 28, 2007 at 02:56:42PM +0700, Vladimir Voroshilov wrote:
> > 2007/7/22, Vladimir Voroshilov <voroshil at gmail.com>:
> > > I've tried to make global variables in tv.c context-dependant.
> > >
> > > Did i do this in right way?
> > > Is patch ok to commit?
> >
> > What about this patch ?
> > Can anybody say some words about it ?
>
> Well, it is an extremely huge patch. IMO it would have been much better
> to do it in several steps, introducing the priv thing, changing some
> trivial stuff, and esp. the options change in a seperate patch, since
> that is the largest part and not quite as obvious as some of the other
> changes.
>
Here is the result of splitting previous patch.
--
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_struct_stream.diff
Type: text/x-diff
Size: 4207 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_tvi_init.diff
Type: text/x-diff
Size: 7878 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3_bsdbt848.diff
Type: text/x-diff
Size: 442 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4_v4l.diff
Type: text/x-diff
Size: 11370 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0003.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5_v4l2.diff
Type: text/x-diff
Size: 7841 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0004.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6_tv.diff
Type: text/x-diff
Size: 11685 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0005.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 7_pvr.diff
Type: text/x-diff
Size: 4523 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0006.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8_tv_noglob.diff
Type: text/x-diff
Size: 7602 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070729/f5865756/attachment-0007.diff>
More information about the MPlayer-dev-eng
mailing list