[MPlayer-dev-eng] [PATCH] Remove global variables from tv.c

[Reimar Doeffinger]

Hello,
On Sat, Jul 28, 2007 at 02:56:42PM +0700, Vladimir Voroshilov wrote:
> 2007/7/22, Vladimir Voroshilov <voroshil at gmail.com>:
> > I've tried to make global variables in tv.c context-dependant.
> >
> > Did i do this in right way?
> > Is patch ok to commit?
> 
> What about this patch ?
> Can anybody say some words about it ?

Well, it is an extremely huge patch. IMO it would have been much better
to do it in several steps, introducing the priv thing, changing some
trivial stuff, and esp. the options change in a seperate patch, since
that is the largest part and not quite as obvious as some of the other
changes.

Some small comments:
> +    if(!tv_param)
> +        return NULL;
> +

Why that check? I think it should never happen.

> +       {"immediatemode", &(stream_tv_defaults.immediate), CONF_TYPE_INT, CONF_RANGE, 0, 1, NULL},

There is no need for the ()

Greetings,
Reimar Doeffinger