[MPlayer-dev-eng] [PATCH] Avoid remapping of X11 window with -wid and -fixed-vo

[Timothy Lee]

Attila Kinali wrote:
> Reimar Döffinger wrote:
>> Can someone comment if the unmap/map cycle is at all necessary? Because
>> during window creation XChangeWindowAttributes is called on a mapped
>> window, and I think it didn't create much problems...
>>     
> As far as I can tell, no, the unmap/map cycle is unneeded, so it
> should be no problem to remove it. What i don't fully understand
> about the patch is why fake_resize is needed.
>
> And btw: what does vo_config_count count?
>
> Other than that and that the doxygen comments are missing it looks ok.
>   
According to libvo.txt, vo_config_count "is set to the number of 
previous config() call, counted from preinit()", and is used by the 
patch to determine whether the video system is being initialized for the 
first time in the case of -fixed-vo.

As for fake_resize(), it is used to emulate an X11 ConfigureNotify 
event, which involves retrieving external window geometry and notifying 
individual vo's using the VO_EVENT_RESIZE flag.  This is necessary 
because the patch skips calling XChangeWindowAttributes() for 
vo_config_count > 0.

Regards,
Timothy