[MPlayer-dev-eng] [PATCH] Avoid remapping of X11 window with -wid and -fixed-vo

Attila Kinali attila at kinali.ch
Wed Jul 25 13:17:00 CEST 2007


On Thu, 19 Jul 2007 09:13:55 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Can someone comment if the unmap/map cycle is at all necessary? Because
> during window creation XChangeWindowAttributes is called on a mapped
> window, and I think it didn't create much problems...

As far as I can tell, no, the unmap/map cycle is unneeded, so it
should be no problem to remove it. What i don't fully understand
about the patch is why fake_resize is needed.

And btw: what does vo_config_count count?

Other than that and that the doxygen comments are missing it looks ok.

			Attila Kinali
-- 
Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred



More information about the MPlayer-dev-eng mailing list