[MPlayer-dev-eng] [PATCH] Refreshed OS/2 Patches

[Attila Kinali]

On Tue, 17 Jul 2007 22:41:00 +0900
KO Myung-Hun <komh at chollian.net> wrote:

> +static uint8_t *m_audioBuf = NULL;
> +static volatile int m_nBufSize = 0;
> +static volatile int m_nBufLen = 0;
> +static volatile int m_iBufPos = 0;

Why the heck are these variables volatile?

You should definitly use standard c types instead of ULONG and
the like. You should generally add more comments in the code
so that even someone w/o OS/2 programming knowledge can understand
it. And finally you should split the kva and dart patches
(rule of thumb: things that do not depend on each other should
be in different patches).

Other than that, someone with an understanding of libao
and libvo should check those patches.

			Attila Kinali

-- 
Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred