[MPlayer-dev-eng] [PATCH] SUN XVR-100 VO driver 3. try

[Balatoni Denes]

Hi!

Thanks for the review Diego, new pathc attached.

Sunday 22 July 2007 23:23-kor Diego Biurrun ezt írta:
> nit: trailing whitespace

Those should be fixed.

>
> > +ioctl(pfb_devfd, VIS_GETIDENTIFIER, &ident)
> > +ioctl(pfb_devfd, FBIOGATTR, &attr)
>
> ioctl is a macro?

I admit the configure part was completly broken, this should be working 
(tested).

> > + * written for xine by
> > + * Robin Kay <komadori [at] gekkou [dot] co [dot] uk>
> > + *
> > + * Sun XVR-100 framebuffer graciously donated by Jake Goerzen.
> > + *
> > + * Ported to mplayer by Denes Balatoni
> > + * Contains portions from the mga and tdfix_vid vo drivers
> > + *
> > + * no double-buffering, as it would slow down playback (waiting for
> > vertical retraces) + * FIXME: only YV12 supported for now
>
> Please put this at the top of the header along with the copyright
> notices.

Done.

>
> > +    if(!(flags & VOFLAG_XOVERLAY_SUB_VO)) {
>
> I prefer a space between if and the opening parentheses.  You use this
> inconsistently.

Done.

>
> Otherwise the patch looks OK from my side.
>
> Diego

bye
Denes

-- 
---
What kills me, doesn't make me stronger.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xvr100_try3.diff
Type: text/x-diff
Size: 18429 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070723/f337381a/attachment.diff>