[MPlayer-dev-eng] [PATCH] SUN XVR-100 VO driver

[Diego Biurrun]

On Wed, Jul 18, 2007 at 10:37:44PM +0200, Balatoni Denes wrote:
> 
> Wednesday 18 July 2007 21:57-kor Compn ezt írta:
> > as diego would say:
> >
> > "Please use a standard license header, compare vidix/vidixlib.c for an
> > example."
> 
> Ok, new patch attached. As a matter of fact, I meant to include a proper 
> license header, only I didn't find one in the files in mplayer I looked at :)

Yes, MPlayer is still messy in that regard.  The situation should be
getting better in the future, though.

> --- mplayer.old/configure	2007-07-18 21:16:00.000000000 +0200
> +++ mplayer/configure	2007-07-18 22:32:40.000000000 +0200
> @@ -3626,6 +3630,32 @@
>  fi
>  echores "$_tdfxvid"
>  
> +echocheck "xvr100"
> +if test "$_xvr100" = auto ; then
> +cat > $TMPC << EOF
> +#include <sys/fbio.h>
> +#include <sys/visual_io.h>
> +int main(void) { 

nit: trailing whitespace

> +ioctl(pfb_devfd, VIS_GETIDENTIFIER, &ident)
> +ioctl(pfb_devfd, FBIOGATTR, &attr)

ioctl is a macro?

> --- mplayer.old/libvo/vo_xvr100.c	1970-01-01 01:00:00.000000000 +0100
> +++ mplayer/libvo/vo_xvr100.c	2007-07-18 22:35:12.000000000 +0200
> @@ -0,0 +1,478 @@
> +/*
> + * SUN XVR-100 (ATI Radeon 7000) VO driver for SPARC Solaris(at least)
> + *
> + * Copyright (C) 2000-2004 Robin Kay <komadori [at] gekkou [dot] co [dot] uk>
> + * Copyright (C) 2004 Jake Goerzen
> + * Copyright (C) 2007 Denes Balatoni
> + *
> + * This file is part of MPlayer.
> + *
> + * MPlayer is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * MPlayer is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with MPlayer; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA              

nit: trailing whitespace

> + * written for xine by
> + * Robin Kay <komadori [at] gekkou [dot] co [dot] uk>
> + *
> + * Sun XVR-100 framebuffer graciously donated by Jake Goerzen.
> + *
> + * Ported to mplayer by Denes Balatoni
> + * Contains portions from the mga and tdfix_vid vo drivers
> + *
> + * no double-buffering, as it would slow down playback (waiting for vertical retraces)
> + * FIXME: only YV12 supported for now

Please put this at the top of the header along with the copyright
notices.

> +    if(!(flags & VOFLAG_XOVERLAY_SUB_VO)) {

I prefer a space between if and the opening parentheses.  You use this
inconsistently.

Otherwise the patch looks OK from my side.

Diego