[MPlayer-dev-eng] [PATCH] Teletext support try3 (2/5, docs)

[Vladimir Voroshilov]

Hi, Diego.

Thanks for review.
I found that i have missed some thinks in docs :)

2007/7/17, Diego Biurrun <diego at biurrun.de>:
> >
> > +teletext_add_dec <value>
> > +    On/off teletext page number editing mode and append given digit to
> > +    previously entered one
>
> I have no idea what the command does or why you chose that name from
> this description.
This is simple page number editing ability. Each call to this command
will append one digit to previously entered.number. When all three
digits are entered, teletext will switch to page with entered number.
Is "teletext_add_digit" better for name ?

I also suggest to make default binding  "KP0 {teletext}
teletext_add_digit 0" and so on to allow jumping between pages
out-of-box.



> > +teletext_go_link <value>
>
> I don't like the name, teletext_follow_link makes more sense to me.
>
> > +    Follow given links on current teletext page
> > +    0    - go to initial page (specified by -tv tpage= parameter)
> > +    1..6 - follow given link
>
> see above
This command is not yet implemented. Thus, removed from man page.

> > +.IPs "X"
> > +Switch teletext between on, off and transparent mode.
> > +.IPs "Q"
> > +Next teletext page.
> > +.IPs "W"
> > +Previous teletext page.
>
> I would say "Switch/go to next/prev teletext page".

.IPs "X"
Switch teletext on/\:off.
.IPs "Q and W"
Go to prev/\:next teletext page.
?

> > +.IPs "E"
> > +In text mode flips top or bottom piece of page otherwise
> > +zooms teletext page: top or bottom or normal.
>
> I don't understand.
This is ability to view only top/bottom half instead of entire page.
Teletext page aspect is about 3/4 while windows window is 4/3.
This can be usefull with sub_scale slave to avoid empty borders on
left and right side of movie.
Anyway, I don't really care about this option. Thus, i suggest to
remove default binding to "E" key from man page and input.c




-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719