[MPlayer-dev-eng] [PATCH] Teletext support try3 (2/5, docs)

[Diego Biurrun]

On Tue, Jul 17, 2007 at 10:20:08PM +0700, Vladimir Voroshilov wrote:
> format (opaque,transparent, etc) and mode (on/off) options/slaves have been 
> splitted.
> Fixed inconsistence with current code.
>
> --- Changelog	(revision 23806)
> +++ Changelog	(working copy)
> @@ -53,6 +53,7 @@
>      * support H.264 over RTSP
>      * "device" and "adevice" suboptions now works for *BSD BT848 tv driver too
>      * dvdnav:// now depends on mplayer's fork of libdvdnav
> +    * Teletext support for tv:// (v4l and v4l2 only)

teletext

> --- DOCS/tech/slave.txt	(revision 23806)
> +++ DOCS/tech/slave.txt	(working copy)
> @@ -322,6 +322,19 @@
>  
> +teletext_add_dec <value>
> +    On/off teletext page number editing mode and append given digit to
> +    previously entered one

I have no idea what the command does or why you chose that name from
this description.

> +    0..9 - append apropriate digit (enables editing mode if called from normal mode, and
> +           switches to normal mode when third digit is entered.

Capitalize, add period and missing ).

> +    -    - delete last digit from page number (backspace amulation, works only in page number
> +           editing mode)

Capitalize, add period.

> +
> +teletext_go_link <value>

I don't like the name, teletext_follow_link makes more sense to me.

> +    Follow given links on current teletext page
> +    0    - go to initial page (specified by -tv tpage= parameter)
> +    1..6 - follow given link

see above

> --- DOCS/man/en/mplayer.1	(revision 23806)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -423,6 +423,26 @@
>  .PP
>  .RS
>  .
> +(The following keys are only valid if teletext support is enabled during
> +compilation: they are used for controlling TV teletext)

Capitalize after the :, add period.

> +.IPs "X"
> +Switch teletext between on, off and transparent mode.
> +.IPs "Q"
> +Next teletext page.
> +.IPs "W"
> +Previous teletext page.

I would say "Switch/go to next/prev teletext page".

> +.IPs "E"
> +In text mode flips top or bottom piece of page otherwise
> +zooms teletext page: top or bottom or normal.

I don't understand.

Diego