[MPlayer-dev-eng] [PATCH] Teletext support try3 (1/5, core)

Alban Bedel albeu at free.fr
Sun Jul 15 14:01:01 CEST 2007


On Sun, 15 Jul 2007 18:01:13 +0700
"Vladimir Voroshilov" <voroshil at gmail.com> wrote:

> +    if(priv_vbi->on!=0 && priv_vbi->input_section==NULL) {
> +        if (NULL==(tmp=mp_input_get_section())) tmp="default";
> +        priv_vbi->input_section=strdup(tmp);
> +        mp_input_set_section("teletext");
> +    }
> +    if(priv_vbi->on==0 && priv_vbi->input_section!=NULL) {
> +        mp_input_set_section(priv_vbi->input_section);
> +        free(priv_vbi->input_section);
> +        priv_vbi->input_section=NULL;
> +    }

This is not acceptable, such UI related code doesn't belong in the
stream layer.

	Albeu




More information about the MPlayer-dev-eng mailing list