[MPlayer-dev-eng] [PATCH] Teletext support try3 (1/5, core)
Vladimir Voroshilov
voroshil at gmail.com
Sun Jul 15 14:04:04 CEST 2007
Hi, Alban
2007/7/15, Alban Bedel <albeu at free.fr>:
> On Sun, 15 Jul 2007 18:01:13 +0700
> "Vladimir Voroshilov" <voroshil at gmail.com> wrote:
>
> > + if(priv_vbi->on!=0 && priv_vbi->input_section==NULL) {
> > + if (NULL==(tmp=mp_input_get_section())) tmp="default";
> > + priv_vbi->input_section=strdup(tmp);
> > + mp_input_set_section("teletext");
> > + }
> > + if(priv_vbi->on==0 && priv_vbi->input_section!=NULL) {
> > + mp_input_set_section(priv_vbi->input_section);
> > + free(priv_vbi->input_section);
> > + priv_vbi->input_section=NULL;
> > + }
>
> This is not acceptable, such UI related code doesn't belong in the
> stream layer.
This is part of "<key> {<section>} <command>" feature support.
I can drop it out ("teletext" input section will be removed, but can
be replaced with "tv" section, though).
Will take in mind in next vresion.
--
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
More information about the MPlayer-dev-eng
mailing list