[MPlayer-dev-eng] [PATCH] OS/2 Patches

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
>>>> @@ -110,6 +123,10 @@
>>>>      {
>>>>          return 1;
>>>>      }
>>>> +#elif defined( __OS2__ )
>>>> +    /* We should consider a case of file ? */
>>>> +
>>>> +    return 1;
>>>>  #else
>>>>      struct stat fileinfo;
>>>>      int ret;
>>>>         
>>> I don't understand the comment.
>>>       
>> It means whether or not we should process a normal file and a block 
>> device such as drive access, separately as Win32 does. But currently 
>> assume a block device mode.
>>     
>
> Why didn't you write something like this in the first place? :)
>
>   

I'm sorry I thought it's enough in context. ^^

>>>> --- configure    (revision 23757)
>>>> +++ configure    (working copy)
>>>> @@ -1175,6 +1185,9 @@
>>>> +  OS/2)
>>>> +    system_name=OS/2
>>>> +    ;;
>>>>         
>>> This is wrong, no system_name mangling is necessary.
>>>       
>> Why ? Without this, the operating system is detected as OS/2-Unknown. 
>> Why should 'Unknown' be followed by 'OS/2' ?
>>     
>
> Your patch does not change the system name.
>
>   

Ok, I would add OS/2 to Linux|... part to maintain system name as OS/2 
not OS/2-Unknown.

>>>> @@ -7402,7 +7479,7 @@
>>>>  LIBDIR = \$(DESTDIR)$_libdir
>>>>  # FFmpeg uses libdir instead of LIBDIR
>>>>  libdir = \$(LIBDIR)
>>>> -#AR = ar
>>>> +AR = $_ar
>>>>  CC = $_cc
>>>>  CXX = $_cc
>>>>  HOST_CC = $_host_cc
>>>>         
>>> This is unused.
>>>       
>> In OS/2, emxomfar can be used instead of ar. Of course, my patches use 
>> emxomfar. So this should be used for compatibility with other OSes.
>>     
>
> Why not use ar if it is available?
>
>   
Because emxomfar use native object format, so it can work with native 
linker and other vendor's compiler. In addition, I prefer emxomfar to 
ar. And although it is not certain, stack problem occur with ar, maybe 
a.out support of OS/2 gcc.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.2
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr