[MPlayer-dev-eng] [PATCH] OS/2 Patches

[Diego Biurrun]

On Thu, Jul 12, 2007 at 11:39:31PM +0900, KO Myung-Hun wrote:
> 
> Diego Biurrun wrote:
> > On Tue, Jul 10, 2007 at 11:13:26PM +0900, KO Myung-Hun wrote:
> >  
> >> --- dvdread/dvd_reader.c    (revision 23757)
> >> +++ dvdread/dvd_reader.c    (working copy)
> >> @@ -460,7 +460,7 @@
> >>              }
> >>              fclose( mntfile );
> >>      }
> >> -#elif defined(__MINGW32__)   
> >> +#elif defined(__MINGW32__) || defined( __OS2__ )
> >>      dev_name = strdup(path);
> >>      auth_drive = DVDOpenImageFile( path, have_css );
> >>  #endif
> >
> > This patch should be sent upstream to libdvdread (as well).
> 
> How to ?
> 
> >> --- libdvdcss/device.c    (revision 23757)
> >> +++ libdvdcss/device.c    (working copy)
> >
> > This patch should be sent upstream to libdvdcss (as well).
> 
> How to ?

Send this to the libdvdcss-devel and the ogle-devel mailing lists.

> >> @@ -110,6 +123,10 @@
> >>      {
> >>          return 1;
> >>      }
> >> +#elif defined( __OS2__ )
> >> +    /* We should consider a case of file ? */
> >> +
> >> +    return 1;
> >>  #else
> >>      struct stat fileinfo;
> >>      int ret;
> >
> > I don't understand the comment.
> 
> It means whether or not we should process a normal file and a block 
> device such as drive access, separately as Win32 does. But currently 
> assume a block device mode.

Why didn't you write something like this in the first place? :)

> >> --- configure    (revision 23757)
> >> +++ configure    (working copy)
> >> @@ -1175,6 +1185,9 @@
> >> +  OS/2)
> >> +    system_name=OS/2
> >> +    ;;
> >
> > This is wrong, no system_name mangling is necessary.
> 
> Why ? Without this, the operating system is detected as OS/2-Unknown. 
> Why should 'Unknown' be followed by 'OS/2' ?

Your patch does not change the system name.

> >> @@ -7402,7 +7479,7 @@
> >>  LIBDIR = \$(DESTDIR)$_libdir
> >>  # FFmpeg uses libdir instead of LIBDIR
> >>  libdir = \$(LIBDIR)
> >> -#AR = ar
> >> +AR = $_ar
> >>  CC = $_cc
> >>  CXX = $_cc
> >>  HOST_CC = $_host_cc
> >
> > This is unused.
> 
> In OS/2, emxomfar can be used instead of ar. Of course, my patches use 
> emxomfar. So this should be used for compatibility with other OSes.

Why not use ar if it is available?

Diego