[MPlayer-dev-eng] [PATCH] replacing printf with mp_msg

[Vladimir Voroshilov]

2007/1/31, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Wed, Jan 31, 2007 at 02:18:51AM +0600, Vladimir Voroshilov wrote:
> > Attached patch replaces all "printf"s with mp_msg(MSGT_LOADER,... in
> > loader/dshow/*
> >
> > What will you say about this small improovement?
>
> Hm. in some ways it is an imported library, so I am not sure if making
> all these changes is such a good idea. On the other hand it seems
> unlikely this will ever by synced with upstream...
Hm, i did not know this fact.
Where can i find this "upstream"?


> But since most are MSGL_DBG4, maybe it would be simpler to redefine
> printf to mp_msg(MSGT_LOADER,MSGL_DBG4 and only replace those with a
> different msgl
In this case i suggest to keep "printf "s (and redefine them to
mp_msg) only in "Debug printf" and commented statements. All messages
with "ERROR" or "Warning" in them should be "mp_msg". Ok?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719