[MPlayer-dev-eng] [PATCH] replacing printf with mp_msg

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Jan 30 21:42:06 CET 2007


Hello,
On Wed, Jan 31, 2007 at 02:18:51AM +0600, Vladimir Voroshilov wrote:
> Attached patch replaces all "printf"s with mp_msg(MSGT_LOADER,... in
> loader/dshow/*
> 
> What will you say about this small improovement?

Hm. in some ways it is an imported library, so I am not sure if making
all these changes is such a good idea. On the other hand it seems
unlikely this will ever by synced with upstream...
But since most are MSGL_DBG4, maybe it would be simpler to redefine
printf to mp_msg(MSGT_LOADER,MSGL_DBG4 and only replace those with a
different msgl

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list