[MPlayer-dev-eng] [PATCH] AVCodecTag redefined when using external libavformat

[Michael Niedermayer]

Hi

On Thu, Jan 25, 2007 at 10:35:20PM +0100, Nico Sabbi wrote:
> sorry for the previous empty post
> 
> Michael Niedermayer wrote:
> 
> >i do object, either include riff.h (ugly and it will break when related
> >things change in lav* but its simple ...) or remove riff.h dependancy
> >that is NEVER include riff.h and NEVER access any internal things from it
> >like codec_bmp_tags but rather use the public interface
> >
> >especiall with .so using the public interface (that 
> >is av_codec_get_id/av_codec_get_tag) and using your own code for keeping
> >track of your own tags seem like a good idea later really is just a matter
> >of copy&paste&rename of AVCodecTag and the 2 tiny functions to access it
> >
> 
> I'm not sure I understood correctly what you mean: duplicating in 
> demux_lavf.c the tables codec_wag_tags and codec_bmp_tags as in the 
> patch attached?

NOOOOOO!


> 
> calling av_codec_get_tag() and av_codec_get_id() requires as 
> parameters the tables we actually need, so how can they be useful in 
> this case?

avi_muxer.codec_tag can be passed to them

and the additional tables mplayer uses cannot use AVCodecTag they can
use MPCodecTag (which may or may not be the same / is copy and pasted
but wont break if AVCodecTag changes)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070128/e247984b/attachment.pgp>