[MPlayer-dev-eng] [PATCH] remove useles ff_gcd prototype in demux_lavf

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Jan 24 23:24:10 CET 2007


Hello,
avutil.h via common.h properly defines ff_gcd, so we shouldn't need that
prototype anymore.
avformat.h currently in some ways already includes the things needed in
some obscure way, but including avutil.h explicitly probably is better.
Is attached patch okay?

Greetings,
Reimar Döffinger
-------------- next part --------------
Index: libmpdemux/demux_lavf.c
===================================================================
--- libmpdemux/demux_lavf.c	(revision 22000)
+++ libmpdemux/demux_lavf.c	(working copy)
@@ -32,9 +32,11 @@
 
 #ifdef USE_LIBAVFORMAT_SO
 #include <ffmpeg/avformat.h>
+#include <ffmpeg/avutil.h>
 #include <ffmpeg/opt.h>
 #else
 #include "avformat.h"
+#include "avutil.h"
 #include "avi.h"
 #include "opt.h"
 #endif
@@ -65,8 +67,6 @@
 extern void print_wave_header(WAVEFORMATEX *h, int verbose_level);
 extern void print_video_header(BITMAPINFOHEADER *h, int verbose_level);
 
-int64_t ff_gcd(int64_t a, int64_t b);
-
 static const AVCodecTag mp_wav_tags[] = {
     { CODEC_ID_ADPCM_4XM,         MKTAG('4', 'X', 'M', 'A')},
     { CODEC_ID_ADPCM_EA,          MKTAG('A', 'D', 'E', 'A')},


More information about the MPlayer-dev-eng mailing list