[MPlayer-dev-eng] [PATCH] AVCodecTag redefined when using external libavformat

[Nico Sabbi]

sorry for the previous empty post

Michael Niedermayer wrote:

> i do object, either include riff.h (ugly and it will break when related
> things change in lav* but its simple ...) or remove riff.h dependancy
> that is NEVER include riff.h and NEVER access any internal things from it
> like codec_bmp_tags but rather use the public interface
> 
> especiall with .so using the public interface (that 
> is av_codec_get_id/av_codec_get_tag) and using your own code for keeping
> track of your own tags seem like a good idea later really is just a matter
> of copy&paste&rename of AVCodecTag and the 2 tiny functions to access it
> 

I'm not sure I understood correctly what you mean: duplicating in 
demux_lavf.c the tables codec_wag_tags and codec_bmp_tags as in the 
patch attached?

calling av_codec_get_tag() and av_codec_get_id() requires as 
parameters the tables we actually need, so how can they be useful in 
this case?



-- 
"Without a frontend, mplayer is useless" - someone in mplayer-users
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavf_riff.diff
Type: text/x-patch
Size: 8818 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070125/cce2df3a/attachment.bin>