[MPlayer-dev-eng] [PATCH] AVCodecTag redefined when using external libavformat

[Nico Sabbi]

Michael Niedermayer wrote:
> Hi
> 
> On Wed, Jan 24, 2007 at 11:06:51PM +0100, Nico Sabbi wrote:
> 
>>Hi,
>>following a simplified version of one of Michael's advices in ffmpeg-devel
>>this patch redefines the structure AVCodecTag (defined in riff.h but not 
>>installed)
>>when  using LIBAVFORMAT_SO (and finally restoring compilation).
>>Michael, if you don't object I'll commit soon
> 
> 
> i do object, either include riff.h (ugly and it will break when related
> things change in lav* but its simple ...) or remove riff.h dependancy
> that is NEVER include riff.h and NEVER access any internal things from it
> like codec_bmp_tags but rather use the public interface
> 
> especiall with .so using the public interface (that 
> is av_codec_get_id/av_codec_get_tag) and using your own code for keeping
> track of your own tags seem like a good idea later really is just a matter
> of copy&paste&rename of AVCodecTag and the 2 tiny functions to access it
> 
> yet another alternative would be to verify that AVCodecTag as it is,
> currently is sufficient for all (de)muxers so that it wont need to
> be changed in the future, in that case it could be moved to avformat.h
> which would also solve this issue
> 
> [...]
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng


-- 
"Without a frontend, mplayer is useless" - someone in mplayer-users