[MPlayer-dev-eng] Re: [PATCH]Play svq3 in X-QT over rtsp

[Carl Eugen Hoyos]

Hi Michael!

On 2007-01-24 01:07, Michael Niedermayer wrote:
[...]
> fixed the extradata crash (but untested)

Yes, thank you! Now, the extradata is not needed anymore to play the video. 
Has it any possible meaning?

I found a second reason for a crash:
...
[svq3 @ 0x87e45d0]picture size invalid (0x0)
[svq3 @ 0x87e45d0]get_buffer() failed (-1 0 0 (nil))

Patch attached.

Carl Eugen

-------------- next part --------------
Index: libavcodec/svq3.c
===================================================================
--- libavcodec/svq3.c	(Revision 7677)
+++ libavcodec/svq3.c	(Arbeitskopie)
@@ -910,7 +910,8 @@
       s->next_p_frame_damaged = 0;
   }
 
-  frame_start (h);
+  if (frame_start (h) < 0)
+    return -1;
 
   if (s->pict_type == B_TYPE) {
     h->frame_num_offset = (h->slice_num - h->prev_frame_num);