[MPlayer-dev-eng] [PATCH] move mousewheel-down event supression to fifo.c

[Mate Miklos]

Hi,

First of all, please ignore my last email in this thread. I don't know what 
happened to me...

I took a second look on this and I changed my mind. Your patch checks _every_ 
incoming event. That's a waste of resources IMHO.

If I was a software designer I would say that drivers should send only 
reliable events, so they need to suppress stuck button presses themselves if 
possible.

Is there any use of mouse button press anyway? Only x11 and sdl sends this 
type of event, the others only send release.

Miklos

On 2007 January 19 Friday 10:54, Reimar Doeffinger wrote:
> Hello,
>
> On Thu, Jan 18, 2007 at 11:40:22PM +0100, Mate Miklos wrote:
> > On 2007 January 18 Thursday 20:48, Reimar Döffinger wrote:
> > > mousewheel down events are supressed because they tend to get stuck
> > > (only space for 10 events in our queue). Instead of having this code
> > > twice in x11_common.c and vo_sdl.c this patch moves it to fifo.c.
> > > That should make both the reason for this "hack" more clear and maybe
> > > make it easier to create a proper solution.
> >
> > Yes, of course this solution is better than mine. I only corrected
> > the ''ignoring'' in those vo drivers.
>
> Thanks for noticing the problem though (and you had hardly a chance of
> finding this solution since that "filtering" in fifo.c was only recently
> added).
>
> Greetings,
> Reimar Döffinger