[MPlayer-dev-eng] [PATCH] move mousewheel-down event supression to fifo.c
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jan 22 16:12:34 CET 2007
Hello,
On Mon, Jan 22, 2007 at 11:51:45AM +0100, Mate Miklos wrote:
> I took a second look on this and I changed my mind. Your patch checks _every_
> incoming event. That's a waste of resources IMHO.
Which probably slows down the processing of key events by about 0.001
percent... If you're pessimistic.
> If I was a software designer I would say that drivers should send only
> reliable events, so they need to suppress stuck button presses themselves if
> possible.
The vo is not where the problem is, it is in fifo.c, as discussed during
the introduction of -key-fifo-size.
Moving this stuff into the vos again will get us further away from a
real fix again.
> Is there any use of mouse button press anyway? Only x11 and sdl sends this
> type of event, the others only send release.
Double-click will not work without it.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list