[MPlayer-dev-eng] Re: [PATCH] VFCTRL_PERIODIC_UPDATE

Diego Biurrun diego at biurrun.de
Fri Jan 19 17:55:13 CET 2007


On Fri, Jan 19, 2007 at 04:42:09PM +0100, Dirk Meyer wrote:
> 
> > I have a feeling the timing loop case would be more insidious, but
> > without actually implementing it this way I'm not sure.  Maybe you can
> > suggest a cleaner way for the pause loop case, but is it as clean as the
> > cmd_filter approach?  And if you find the cmd_filter way unelegant (or
> > even less elegant), why?
> [...]
> > Your thoughts?
> 
> Is there any chance this patch will be included into mplayer? It is
> needed for the freevo osd on top of a movie. It would help if you at
> least tell us to go away if you won't include the patch. In that case
> we won't try to get patches merged which would save us some time.

I have no idea where your current frustration comes from, but here's a
general statement: We're always happy to receive (good) patches and we
do our best to review and apply them all.  We're especially happy if
projects that reuse MPlayer attempt to integrate their changes back.
Unfortunately we're short on manpower.  Not that many developers review
patches and we get flooded.  Please be patient if reviews take a little
longer, just send a polite reminder once in a while.

Now this particular patch was discussed actively.  I didn't follow too
closely but it appears that the discussion did not come to a conclusion.
Try to address the comments that were made and the patch will eventually
be accepted.

Diego



More information about the MPlayer-dev-eng mailing list