[MPlayer-dev-eng] Re: [PATCH] Identify DRM protected asf file

[Michael Niedermayer]

Hi

On Sun, Feb 25, 2007 at 11:12:07PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Sunday, 25 February 2007 at 03:39, Compn wrote:
> > Zuxy Meng <zuxy.meng <at> gmail.com> writes:
> > 
> > > > i'm against mplayer quitting on drm files. mplayer should try to play the 
> > file
> > > > in case its broken or detection isnt 100%.
> > > 
> > > Updated patch attached. Anyway lavf will catch it if mplayer's asf
> > > demuxer fails, so let things go on may not be a bad idea.
> > > 
> > > >
> > > > otherwise this would be a highly wanted feature! lots of users in #mplayer 
> > with
> > > > drm files.
> > > 
> > 
> > http://article.gmane.org/gmane.comp.video.mplayer.devel/40341
> > 
> > this will be committed in next few days unless someone speaks up.
> 
> Just one small comment:
> 
> +#define MSGTR_MPDEMUX_ASFHDR_DRMProtected "Content is DRM protected and cannot be played by MPlayer!\n"
> 
> Please, do s/protected/restricted/g . Calling it "protected" implies it may
> be a good thing. I'm sure we don't want to send such message to the user.

hmmmmm, what about "infected", "contaminated"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070225/7e75ace0/attachment.pgp>