[MPlayer-dev-eng] Re: [PATCH] Identify DRM protected asf file

[Dominik 'Rathann' Mierzejewski]

On Sunday, 25 February 2007 at 03:39, Compn wrote:
> Zuxy Meng <zuxy.meng <at> gmail.com> writes:
> 
> > > i'm against mplayer quitting on drm files. mplayer should try to play the 
> file
> > > in case its broken or detection isnt 100%.
> > 
> > Updated patch attached. Anyway lavf will catch it if mplayer's asf
> > demuxer fails, so let things go on may not be a bad idea.
> > 
> > >
> > > otherwise this would be a highly wanted feature! lots of users in #mplayer 
> with
> > > drm files.
> > 
> 
> http://article.gmane.org/gmane.comp.video.mplayer.devel/40341
> 
> this will be committed in next few days unless someone speaks up.

Just one small comment:

+#define MSGTR_MPDEMUX_ASFHDR_DRMProtected "Content is DRM protected and cannot be played by MPlayer!\n"

Please, do s/protected/restricted/g . Calling it "protected" implies it may
be a good thing. I'm sure we don't want to send such message to the user.

Otherwise I say commit immediately.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan