[MPlayer-dev-eng] [RFC][PATCH] audio and video framers

Michael Niedermayer michaelni at gmx.at
Sun Feb 25 12:31:11 CET 2007


On Sun, Feb 25, 2007 at 10:27:16AM +0100, Nico Sabbi wrote:
> Rich Felker wrote:
> >On Sun, Feb 25, 2007 at 03:14:27AM +0100, Michael Niedermayer wrote:
> >>any reason besides NIH syndrom that you dont just use the AVParsers?
> >
> >
> >Indeed: MPlayer should be moving towards using lavc/lavf more and
> >dropping libmpdemux eventually. I'm against adding a new layer like
> >this when we could just use AVParser.
> >
> >Rich
> as long as we have libmpdemux I'd like to keep it as clean as 
> possible. Moving all code to handle mpeg1/2/4 and h264 from video.c
> to the appropriate framer would clean the code a lot. don't you agree?

certainly, so your patch just moves code? if so iam sorry for complaining
i just read your message not the code, if OTOH it introduces new Framers
then i really think you move in the wrong direction, as you duplicate
the existing AVParser with no technical reason,  if there where one i 
would like to know it so i can improve the AVParsers

and rewriting AVParsers will be more work than you think, there are
plenty special cases to deal with and correct timestamp reordering 
for MPEG* is not easy mplayers handling of them is IIRC completely wrong

i would suggest to merge the mplayer framers which are hacked into various
parts of the code with AVParser and use AVParser instead
the dependancy on lavc surely is there but so is there a dependancy on
your framer code, 
avoiding dependancy on existing code == NIH syndrom

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070225/515e1bc1/attachment.pgp>

More information about the MPlayer-dev-eng mailing list