[MPlayer-dev-eng] Re: [PATCH] fix potential bug in loader/dshow/outputpin.c

[Vladimir Voroshilov]

2007/2/10, Vladimir Voroshilov <voroshil at gmail.com>:
> Hi, All.
>
> DirectShow AM_MEDIA_TYPE structure has pbFormat pointer to additional
> media type's data.
>
> 1. Some methods does copying of this structure without copying
> additional data, pointed by pbFormat. As result two structures will
> point to the same block of additional data.
> Freeing original and copyed structure could cause double free of the
> same memory region.
> 2. some methods does freeing of AM_MEDIA_TYPE without freeing
> additional data (memory leak)
> 3. malloc return does not beeing checked for NULL value (out of memory).
> Patch fixes all 3 issues.
Fixed in r22323

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719