[MPlayer-dev-eng] [PATCH] fix potential bug in loader/dshow/outputpin.c

Roberto Togni rxt at rtogni.it
Sat Feb 10 15:56:56 CET 2007

On Sat, 10 Feb 2007 20:37:13 +0600
"Vladimir Voroshilov" <voroshil at gmail.com> wrote:


> I also thinks that this freeing code (and related to media type
> structure operations) should be implemented as separate functions
> (DeleteMediaType and related). this will simplify code and prevent
> such bugs in future. Unfortunately, i don't know where to put this
> methods to (win32.c is not good place for me).

Hmm, if it's part of the dshow interface it should go with that code;
iirc dshow glue code is used also in windows, while win32.c is used to
provide win32 api on non-win32 systems.
If it's something that is called by the codec dll then win32.c is the
obvious place, since on windows it will call the native function; if
it's called by our dshow code just put them in dshow directory.

But since this all sounds too simple, I'm probably missing what the real
problem is :(


More information about the MPlayer-dev-eng mailing list