[MPlayer-dev-eng] Re: [PATCH] Resolve bugzilla bug #16

Vladimir Voroshilov voroshil at gmail.com
Mon Feb 19 13:52:59 CET 2007


> I think, that this codec uses information about input allocator to set
> properties for output memory allocator and without this patch codec
> does know nothing about input allocator properties (because
> NotifyAllocator did not called yet) at start time and sets output
> allocator properties in "run" method using uninitialized internal
> variables.
Bug exists only under win32, because under linux both pins uses
MPlayer's MemAllocator class (with usable default values for buffer
size), but under win32 inputpin uses DirectShow's implementation of
IMemAllocator interface (with buffer count=0 and buffer size=1). Codec
does not do MemAllocator initialization for input pin (and it
should'nt i think. Allocator's properties are choosed by OutputPin,
IIRC) and default value (0 buffers of 1 byte size) are used.

> This patch was tested (only for voxware) under mingw and works fine for me.
Also tested with "realaud" and "raatrcwin" binary codecs.

> Please review it and test for regression, if possible.

Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at jabber.ru
ICQ: 95587719

More information about the MPlayer-dev-eng mailing list