[MPlayer-dev-eng] [PATCH] crap removal from video.c

[Roberto Togni]

On Fri, 09 Feb 2007 21:34:01 +0100
Nico Sabbi <nicola_sabbi at fastwebnet.it> wrote:

> Over the years an unbearable amount of #if0-ed and commented code 
> stockpiled in video.c;
> I believe that it's time to remove it and I guarantee that no one
> will ever regret it, because
> there's highly insane code (tampering with the bitstream, flipping 
> frames, etc).
> If no one objects I'll commit it tomorrow
> 
> 
> @ -510,21 +452,11 @@
>  	      case 0x100: picture_coding_type=(videobuffer[start+1]
> >> 3) & 7;break; }
>          }
> -        
> -        // if(videobuf_len>max_framesize)
> max_framesize=videobuf_len; // debug
> -        //printf("--- SEND %d bytes\n",videobuf_len);
> -//	if(grab_frames==1){
> -//	      FILE *f=fopen("grab.mpg","ab");
> -//	      fwrite(videobuffer,videobuf_len-4,1,f);
> -//	      fclose(f);
> -//	}
>  
>  	*start=videobuffer; in_size=videobuf_len;
> -	//blit_frame=decode_video(video_out,sh_video,videobuffer,videobuf_len,drop_frame);
>  
>  #if 1

^^^^^^^^^
Too late, but what about this? Any reason to keep it?

>      // get mpeg fps:
> -    //newfps=frameratecode2framerate[picture->frame_rate_code]*0.0001f;
>      if(sh_video->fps!=picture.fps) if(!force_fps && !telecine){
>              mp_msg(MSGT_CPLAYER,MSGL_WARN,"Warning! FPS changed
> %5.3f -> %5.3f  (%f) [%d]
> \n",sh_video->fps,picture.fps,sh_video->fps-picture.fps,picture.frame_rate_code);
> sh_video->fps=picture.fps; @@ -558,7 +490,6 @@ } else
> if((demuxer->file_format==DEMUXER_TYPE_MPEG4_ES) ||
> ((demuxer->file_format==DEMUXER_TYPE_MPEG_TS) &&
> (sh_video->format==0x10000004)) ||

[...]

Ciao,
 Roberto