[MPlayer-dev-eng] Re: PATCH [2/12] CoreAVC Decoder Support

[Alan Nisota]

Alan Nisota writes:
> 
> To be fair, getting this codec to work has been very tricky.  It is quite 
> possible that I can rework this patch to be more flexible.  We have a list of 
> known output formats in codecs.conf, perhaps we can choose one of those for 
the 
> initial dest fmt (or we can ask the codec to suggest one, that should work as 
> well and would be easier to implement.
> 
I looked at it, and adding support for EnumMediaTypes may prove tricky 
(certainly the patch is reasonably large).  Also, it is complicated by 
EnumMediaTypes->Next allocating an AM_MEDIA_TYPE structure, which I'm not sure 
how to free.  To free it, you need to call the windows DeleteMediaType (which 
isn't implemented in win32.c but could easily be), but I am not sure how to 
reliably call a Windows API function from within mplayer on multiple platforms.
Alternatively, we could remove the ReceiveConnect of the output pin from 
DS_FilterCreate, and only do it in DS_VideoDecoder_SetDestFmt when we know what 
format we want.  However I'm not convinced it is worthwhile, considering that 
YV12 is a very common output format.  It may just be easier to change the 
default.