[MPlayer-dev-eng] Re: PATCH [7/12] CoreAVC Decoder Support

[Alan Nisota]

Reimar Döffinger writes:
> >      for(i=0; i<min(srclen, destlen); i++)
> >      {
> >  	*dest=(char)*src;
> > -	dest++;
> > -	src++;
> >  	if(*src==0)
> >  	    return i+1;
> > +	dest++;
> > +	src++;
> >      }
> 
> This looks like a bugfix that should be handled independent from the
> rest.
> Also the same problem seems unfixed for the dest == 0 case.
> And finally I think the "return i+1;" is now wrong, it must be "return i;"
My first response to this seems to have gotten lost, so here it is again 
(properly threaded this time I hope):

The 'i+1' is right.  These functions should return the length including the 
trailing '\0' and i is the index not the length.  You are right about the 
dest==0 case though.  I'll fix it.