[MPlayer-dev-eng] PATCH [7/12] CoreAVC Decoder Support

[Reimar Döffinger]

Hello,
On Thu, Feb 08, 2007 at 02:09:09PM -0800, Alan Nisota wrote:
> 007widereg.patch: adds support for Querying registry items as wide 
> strings.  the strings are always stored as standard char strings, so it 
> just converts back-and-forth

> Index: loader/ext.c
> ===================================================================
> --- loader/ext.c.orig	2007-02-07 22:56:49.000000000 -0800
> +++ loader/ext.c	2007-02-07 22:57:39.000000000 -0800
> @@ -581,17 +581,30 @@
>      for(i=0; i<min(srclen, destlen); i++)
>      {
>  	*dest=(char)*src;
> -	dest++;
> -	src++;
>  	if(*src==0)
>  	    return i+1;
> +	dest++;
> +	src++;
>      }

This looks like a bugfix that should be handled independent from the
rest.
Also the same problem seems unfixed for the dest == 0 case.
And finally I think the "return i+1;" is now wrong, it must be "return i;"

Greetings,
Reimar Döffinger