[MPlayer-dev-eng] Re: PATCH [5/12] CoreAVC Decoder Support

[Alan Nisota]

Reimar wrote:

     > Index: loader/win32.c
     > ===================================================================
     > --- loader/win32.c.orig    2007-02-07 22:58:12.000000000 -0800
     > +++ loader/win32.c    2007-02-07 22:58:18.000000000 -0800
     > @@ -3603,7 +3603,7 @@
     >      dbgprintf("CreateFileA(0x%x='%s', %d, %d, 0x%x, %d, %d,
    0x%x)\n", cs1, cs1, i1,
     >            i2, p1, i3, i4, i5);
     >      if((!cs1) || (strlen(cs1)<2))return -1;
     > -
     > +    if(strstr(cs1, "\\\\.\\")) return -1; //Hack for PECompact2

    Is this really supposed to be strstr and not strncmp

You are correct:
    if(strncmp(cs1, "\\\\.\\", 4) == 0) return -1; //Hack for PECompact2
Would be better.

I'll repost the patch after a while if there's no more feedback.