[MPlayer-dev-eng] Re: Trailing whitespace removal and precommit hooks

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Feb 7 10:28:37 CET 2007


Hello,
On Wed, Feb 07, 2007 at 09:37:20AM +0300, Evgeniy Stepanov wrote:
> On Wednesday 07 February 2007 08:39, Robert Henney wrote:
> > What about having the pre-commit script do the silent removal of
> > trailing whitespace (on patch inserted lines) instead of it rejecting
> > if it finds any?

I find that not acceptable, patches should not be meddled with by a
script without being checked by a developer IMO.
> 
> Or, it can allow anything, but mark such changes in cvslog list. Then the 
> committer could be flamed in the ML :)

Probably difficult to implement in a sane but would be good enough to
me.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list