[MPlayer-dev-eng] Trailing whitespace removal and precommit hooks

Guillaume POIRIER poirierg at gmail.com
Wed Feb 7 10:18:59 CET 2007


On 2/7/07, Diego Biurrun <diego at biurrun.de> wrote:
> On Tue, Feb 06, 2007 at 04:03:38PM +0100, Guillaume POIRIER wrote:
> >
> > On 2/1/07, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>
> > wrote:
> > >is anyone against installing a precommit hook that will disallow adding
> > >trailing whitespace?
> >
> > I'm a bit late to comment on the subject, but while I like the idea of
> > not having trailing spaces snucking in, based on my experience with
> > ffmpeg's pre-commit script, it's really a pain sometimes when I apply
> > a 3rd party patch that contains such spaces, especially when I'm not
> > using my favourite text editor that can automatically "fix" this
> > problem.
> Have you tried the clean-diff script from the root of the FFmpeg source
> tree?

Damn!! All this time I wasted by manually fixing patches, and now I
found out that there's a script that do it for me?
Oh man!
I just tested it, it works, so I definitely have not objection to the
pre-commit script.


More information about the MPlayer-dev-eng mailing list