[MPlayer-dev-eng] [PATCH] make mplayer's liblzo support compile with lzo 2.x

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Feb 1 01:09:41 CET 2007


Hello,
On Fri, Jan 26, 2007 at 05:08:20PM +0100, Carl Eugen Hoyos wrote:
> On 2007-01-17 14:29, Bernhard Rosenkraenzer wrote:
> > SSIA -- the patch is about as simple as it can get, given the API is almost 
> > unchanged.
> 
> Unfortunately, Oberhumer decided to change the installation directory for 
> lzo1x.h to .../include/lzo for version 2:  
> http://www.oberhumer.com/opensource/lzo/lzonews.php (Misc), so I don't think 
> your patch will help for typical(?) installations.
> 
> But why keep support for liblzo1? Most libraries are only supported by mplayer 
> if their newest versions are used. What about the attached patch?

With latest changes liblzo is no longer used. But ve_nuv.c depends on
our minilzo. IMO it would be preferable to apply the configure part of
this patch, change ve_nuv.c to use liblzo (hopefully someone volunteers,
should be at most 4 lines), and remove minilzo.
Requiring liblzo2 for something that is as obscure as I believe ve_nuv
to be is okay IMO...

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list