[MPlayer-dev-eng] Trailing whitespace removal and precommit hooks

Roberto Togni rxt at rtogni.it
Thu Feb 1 22:11:45 CET 2007

On Thu, 1 Feb 2007 00:41:00 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> is anyone against installing a precommit hook that will disallow adding
> trailing whitespace? As a preparation to that it would also be necessary
> to remove all that are currently there in a cosmetics patch...
> I am in favour of it, and also of doing it in a way that will disallow
> whitespace-only lines (IIRC someone preferred to keep them, if that is so,
> how important is that?).

I found trailing whitespaces totally harmless, so I'm against it.
I could agree to a one-time patch to remove spaces and tabs from empty
lines, as long as their number is low; if the patch is bg and/or
affects too many files I'm against it. But even in this case I won't
support forbidding commits of patches with spaces on empty lines.

And I'm against any kind of precommit scripts: something that aborts a
commit for silly reasons is very annoying.


More information about the MPlayer-dev-eng mailing list