[MPlayer-dev-eng] Trailing whitespace removal and precommit hooks

Diego Biurrun diego at biurrun.de
Thu Feb 1 01:54:06 CET 2007


On Thu, Feb 01, 2007 at 02:29:10AM +0200, Ivan Kalvachev wrote:
> 2007/2/1, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> >is anyone against installing a precommit hook that will disallow adding
> >trailing whitespace? As a preparation to that it would also be necessary
> >to remove all that are currently there in a cosmetics patch...
> >I am in favour of it, and also of doing it in a way that will disallow
> >whitespace-only lines (IIRC someone preferred to keep them, if that is so,
> >how important is that?).
> 
> What do you mean by whitespace-only lines? Would you remove the lines
> or only the whitespaces in them?
> 
> I don't mind removing whitespaces from empty lines.

Only the whitespace.

> Also, would that be in power only for .[ch] files or for all other
> text files (Makefile,man,xml)?

While we're at it, all of them.

Diego




More information about the MPlayer-dev-eng mailing list