[MPlayer-dev-eng] [PATCH] fix undersized colorkey with xv

[Ivan Kalvachev]

On Dec 28, 2007 4:36 PM, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
>
> On Dec 28, 2007 2:26 PM,  <aflist2 at gmail.com> wrote:
> > hello,
> >
> > a small black line is visible on the right and bottom of a vo=xv
> > display because the colorkey is too small by one pixel in width and
> > height.
> >
> > no ill effect on panscan ability was detected on a few test files.
>
> Patch OK.

> I really wonder why it have been done this way to begin with (the
> corresponding call in xvmc is not using less-than-one dimensions).

I don't wonder anymore, the X manual indicates that it fill rectangle
with coordinates:
[x,y][x+width,y][x+width,y+height][x,y+height]

That indicates that having x=y=width=height=1; would fill rectangle
with coordinates
[1,1][1,2]
[2,1][2,2]