[MPlayer-dev-eng] [PATCH] Use XScreenSaverSuspend if supported

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Dec 22 12:24:39 CET 2007


Hello,
On Fri, Dec 21, 2007 at 10:33:33PM +0200, Ivan Kalvachev wrote:
[...]
> Reimar, I'm against KDE removal and exactly because there are KDE
> versions that doesn't honor XSS. However I think that it should only
> be triggered by command line (aka
> -stop-screensaver=kde/gnome/xscreensaver ). I won't mind if all this
> crap is removed if we commit the event generator (mouse movement
> etc...).

The KDE thing is exactly one of the completely broken things that
leaves the screensaver disabled forever if e.g. MPlayer crashes.
Even a -screensaveer-ping-cmd option or something like that which is
called via system on each xscreensaver_heartbeat seems better to me.
We just should make it very clear that it's not our problem if they
decide to use this and end up putting something exploitable in (e.g.
something involving "./file") instead of fixing their screensaver.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list