[MPlayer-dev-eng] [PATCH] set is_streamed correctly in lavf URLContext

[Rich Felker]

On Wed, Dec 19, 2007 at 03:07:44AM +0100, Michael Niedermayer wrote:
> On Tue, Dec 18, 2007 at 10:22:43PM +0100, Reimar Döffinger wrote:
> > Hello,
> > On Tue, Dec 18, 2007 at 08:24:41PM +0100, Michael Niedermayer wrote:
> > > On Sat, Dec 15, 2007 at 05:35:19PM +0100, Reimar Döffinger wrote:
> > [...]
> > > >  typedef struct lavf_priv_t{
> > > >      AVInputFormat *avif;
> > > >      AVFormatContext *avfc;
> > > > -    ByteIOContext *pb;
> > > > +    ByteIOContext pb;
> > > > +    uint8_t buffer[BIO_BUFFER_SIZE];
> > > 
> > > you assume that sizeof(ByteIOContext) will not change between lavf versions,
> > > or you just dont care that it will break even with minor version bumps ... :)
> > 
> > Actually the later one...
> 
> dont you care a little bit about compatibility? with such design you could
> drop shared lib libav* support from mplayer

I would be very much in favor of dropping shared support.

Rich