[MPlayer-dev-eng] [PATCH] set is_streamed correctly in lavf URLContext

[Michael Niedermayer]

On Tue, Dec 18, 2007 at 10:22:43PM +0100, Reimar Döffinger wrote:
> Hello,
> On Tue, Dec 18, 2007 at 08:24:41PM +0100, Michael Niedermayer wrote:
> > On Sat, Dec 15, 2007 at 05:35:19PM +0100, Reimar Döffinger wrote:
> [...]
> > >  typedef struct lavf_priv_t{
> > >      AVInputFormat *avif;
> > >      AVFormatContext *avfc;
> > > -    ByteIOContext *pb;
> > > +    ByteIOContext pb;
> > > +    uint8_t buffer[BIO_BUFFER_SIZE];
> > 
> > you assume that sizeof(ByteIOContext) will not change between lavf versions,
> > or you just dont care that it will break even with minor version bumps ... :)
> 
> Actually the later one...

dont you care a little bit about compatibility? with such design you could
drop shared lib libav* support from mplayer


> Should I add a alloc_put_byte that allocates and calls init_put_byte?

i guess that would be an option

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071219/f1e49ba1/attachment.pgp>