[MPlayer-dev-eng] [PATCH] set is_streamed correctly in lavf URLContext

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Dec 18 22:22:43 CET 2007


Hello,
On Tue, Dec 18, 2007 at 08:24:41PM +0100, Michael Niedermayer wrote:
> On Sat, Dec 15, 2007 at 05:35:19PM +0100, Reimar Döffinger wrote:
[...]
> >  typedef struct lavf_priv_t{
> >      AVInputFormat *avif;
> >      AVFormatContext *avfc;
> > -    ByteIOContext *pb;
> > +    ByteIOContext pb;
> > +    uint8_t buffer[BIO_BUFFER_SIZE];
> 
> you assume that sizeof(ByteIOContext) will not change between lavf versions,
> or you just dont care that it will break even with minor version bumps ... :)

Actually the later one...
Should I add a alloc_put_byte that allocates and calls init_put_byte?
Other possibilities include a simple alloc-only function or a size constant.
Or misusing url_open_buf ;-)

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list